Move Redux module type extension into a separate imported file #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously merged a PR that would globally override the types from the Redux core package and patch the `Dispatch` type to _always_ assume that the thunk middleware is installed. However, that assumption is not always true, and globally overriding types is a dangerous approach to have as a default. This commit moves the global overrides into a separate types file, which can now be imported as 'redux-thunk/extend-redux'. This allows users to still opt in to that behavior if desired. The typetest files have been updated to compare the behavior with and without importing the override file.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Dispatchtype" declaration to a separateextend-redux.d.tstypes filefileslist to include that in the published packageNotes per commit:
We previously merged a PR that would globally override the types
from the Redux core package and patch the
Dispatchtype toalways assume that the thunk middleware is installed.
However, that assumption is not always true, and globally
overriding types is a dangerous approach to have as a default.
This commit moves the global overrides into a separate types file,
which can now be imported as 'redux-thunk/extend-redux'. This
allows users to still opt in to that behavior if desired.
The typetest files have been updated to compare the behavior with
and without importing the override file.